Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging configuration #58

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Improve logging configuration #58

merged 4 commits into from
Feb 9, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 9, 2024

Part of #5.

This PR does the following:

  • Emits a log event before & after each HTTP request made to the Dandi Archive and datasets.datalad.org (and also to S3 when determining a bucket's region)
  • Configures logging to be emitted on stderr instead of stdout
  • Configures logging to not use ANSI colors when stderr is redirected
  • Configures logging to show all events from dandidav and certain select "important" libraries, along with all INFO & above events from all other libraries

@jwodder jwodder added the logging label Feb 9, 2024
@jwodder jwodder mentioned this pull request Feb 9, 2024
Open
14 tasks
@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (a561bfa) 35.09% compared to head (95f30fe) 34.73%.

Files Patch % Lines
src/httputil.rs 0.00% 57 Missing ⚠️
src/main.rs 0.00% 14 Missing ⚠️
src/s3.rs 0.00% 9 Missing ⚠️
src/zarrman/mod.rs 0.00% 4 Missing ⚠️
src/dandi/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   35.09%   34.73%   -0.37%     
==========================================
  Files          23       23              
  Lines        3328     3363      +35     
==========================================
  Hits         1168     1168              
- Misses       2160     2195      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder merged commit 5bc4b92 into main Feb 9, 2024
7 of 9 checks passed
@jwodder jwodder deleted the logconf branch February 9, 2024 15:37
jwodder added a commit that referenced this pull request Feb 9, 2024
@jwodder
[skip ci] Add changelog item for #58
d72b89a
jwodder added a commit that referenced this pull request Feb 9, 2024
@jwodder
Merge pull request #60 from dandi/up-changelog
791a3ea 
Add changelog item for #58
@jwodder jwodder mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jwodder